Skip to content

Wrap file writer in ray #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 4 commits into from
Jun 17, 2025
Merged

Wrap file writer in ray #82

pan-x-c merged 4 commits into from
Jun 17, 2025

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jun 17, 2025 •
edited
Loading

Description

  1. Wrap file writer in ray
  2. The file/sql path is automatically chosen based on checkpoint_root_dir

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented Jun 17, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
28 26 2 0 0 0 0 852ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool The test failed in the call phase due to an assertion error
❌ tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models The test failed in the call phase due to an assertion error

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/file_test.py::TestFileReader::test_file_reader ✅ 1ms
tests/buffer/file_test.py::TestFileReader::test_file_writer ✅ 3ms
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 3ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 2ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 38ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 23ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 124ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 147ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ❌ 5ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ❌ 5ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 286ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 3ms

Github Test Reporter by CTRF 💚

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented Jun 17, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
28 28 0 0 0 0 0 861ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/file_test.py::TestFileReader::test_file_reader ✅ 1ms
tests/buffer/file_test.py::TestFileReader::test_file_writer ✅ 3ms
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 3ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 2ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 123ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 143ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 19ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ✅ 3ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 288ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 3ms

Github Test Reporter by CTRF 💚

yanxi-chen
yanxi-chen approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@yanxi-chen yanxi-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pan-x-c pan-x-c merged commit ad77ffe into modelscope:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanxi-chen yanxi-chen yanxi-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pan-x-c @yanxi-chen